[
https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=646774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646774
]
ASF GitHub Bot logged work on HIVE-23633:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/21 07:54
Start Date: 06/Sep/21 07:54
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2344:
URL: https://github.com/apache/hive/pull/2344#discussion_r702683846
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1554,41 +1553,45 @@ private boolean dropCreationMetadata(String catName,
String dbName, String table
constraintname =
constraintname!=null?normalizeIdentifier(constraintname):null;
List<MConstraint> mConstraints = null;
List<String> constraintNames = new ArrayList<>();
- Query query = null;
+ Query queryForConstraintName = null;
+ Query queryForMConstraint = null;
try {
- query = pm.newQuery("select constraintName from
org.apache.hadoop.hive.metastore.model.MConstraint where "
+ queryForConstraintName = pm.newQuery("select constraintName from
org.apache.hadoop.hive.metastore.model.MConstraint where "
Review comment:
Could we use try-with-resources here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646774)
Time Spent: 10.5h (was: 10h 20m)
> Metastore some JDO query objects do not close properly
> ------------------------------------------------------
>
> Key: HIVE-23633
> URL: https://issues.apache.org/jira/browse/HIVE-23633
> Project: Hive
> Issue Type: Bug
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23633.01.patch
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895],
> The metastore still has seen a memory leak on db resources: many
> StatementImpls left unclosed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
