[ https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=645214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645214 ]
ASF GitHub Bot logged work on HIVE-23633: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Sep/21 10:52 Start Date: 01/Sep/21 10:52 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #2344: URL: https://github.com/apache/hive/pull/2344#issuecomment-910165905 > Thanks for catching this! > > We should close all the queries, even if there is an exception. > Since Java 8 closing queries in `try-with-resources` would be the best if possible, falling back to `finally` when not possible is the second best. Thank you for the review! Introduces a new QueryWrapper to avoid superfluous exception handing when using `try-with-resources` with the class `Query` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 645214) Time Spent: 9h 20m (was: 9h 10m) > Metastore some JDO query objects do not close properly > ------------------------------------------------------ > > Key: HIVE-23633 > URL: https://issues.apache.org/jira/browse/HIVE-23633 > Project: Hive > Issue Type: Bug > Reporter: Zhihua Deng > Assignee: Zhihua Deng > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-23633.01.patch > > Time Spent: 9h 20m > Remaining Estimate: 0h > > After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895], > The metastore still has seen a memory leak on db resources: many > StatementImpls left unclosed. -- This message was sent by Atlassian Jira (v8.3.4#803005)