[ https://issues.apache.org/jira/browse/HIVE-25453?focusedWorklogId=641014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641014 ]
ASF GitHub Bot logged work on HIVE-25453: ----------------------------------------- Author: ASF GitHub Bot Created on: 24/Aug/21 09:27 Start Date: 24/Aug/21 09:27 Worklog Time Spent: 10m Work Description: pvary commented on a change in pull request #2586: URL: https://github.com/apache/hive/pull/2586#discussion_r694679451 ########## File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java ########## @@ -247,6 +243,12 @@ public OrcEncodedDataReader(LowLevelCache lowLevelCache, BufferUsageManager buff this.jobConf = jobConf; // TODO: setFileMetadata could just create schema. Called in two places; clean up later. this.evolution = sef.createSchemaEvolution(fileMetadata.getSchema()); + + fileIncludes = includes.generateFileIncludes(fileSchema); Review comment: What happens if there are multiple files with different schema? The test data is created this way: - Iceberg table created with 2 columns - Data inserted with 2 columns - Iceberg table schema modified - Data inserted with the modified schema ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 641014) Time Spent: 1h 50m (was: 1h 40m) > Add LLAP IO support for Iceberg ORC tables > ------------------------------------------ > > Key: HIVE-25453 > URL: https://issues.apache.org/jira/browse/HIVE-25453 > Project: Hive > Issue Type: New Feature > Reporter: Ádám Szita > Assignee: Ádám Szita > Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)