[ 
https://issues.apache.org/jira/browse/HIVE-25453?focusedWorklogId=641009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641009
 ]

ASF GitHub Bot logged work on HIVE-25453:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/21 09:18
            Start Date: 24/Aug/21 09:18
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2586:
URL: https://github.com/apache/hive/pull/2586#discussion_r694672513



##########
File path: 
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
##########
@@ -720,13 +750,54 @@ public SchemaEvolution 
createSchemaEvolution(TypeDescription fileSchema) {
           readerSchema, readerLogicalColumnIds);
       Reader.Options options = new Reader.Options(jobConf)
           .include(readerIncludes).includeAcidColumns(includeAcidColumns);
-      return new SchemaEvolution(fileSchema, readerSchema, options);
+      evolution = new SchemaEvolution(fileSchema, readerSchema, options);
+
+      generateLogicalOrderedColumnIds();
+      return evolution;
+    }
+
+    /**
+     * LLAP IO always returns the column vectors in the order as they are seen 
in the file.
+     * To support logical column reordering, we need to do a matching between 
file and read schemas.
+     * (this only supports one level of schema reordering, not within complex 
types, also not supported for ORC ACID)
+     */
+    private void generateLogicalOrderedColumnIds() {

Review comment:
       Maybe some debug level logging?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 641009)
    Time Spent: 1h 20m  (was: 1h 10m)

> Add LLAP IO support for Iceberg ORC tables
> ------------------------------------------
>
>                 Key: HIVE-25453
>                 URL: https://issues.apache.org/jira/browse/HIVE-25453
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Ádám Szita
>            Assignee: Ádám Szita
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to