[
https://issues.apache.org/jira/browse/HIVE-25362?focusedWorklogId=626517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626517
]
ASF GitHub Bot logged work on HIVE-25362:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 09:25
Start Date: 22/Jul/21 09:25
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #2513:
URL: https://github.com/apache/hive/pull/2513#discussion_r674637137
##########
File path:
llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
##########
@@ -904,6 +904,48 @@ private void forceLocalityTest1(boolean forceLocality)
throws IOException, Inter
}
}
+ @Test(timeout = 10000)
Review comment:
this unit test passes also without the patch, could you please include
some assertion proving this fix? I believe it should assert that in case of no
available hosts request.resetLocalityDelayInfo() is not called (if I understood
the point of this patch correctly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626517)
Time Spent: 0.5h (was: 20m)
> LLAP: ensure tasks with locality have a chance to adjust delay
> --------------------------------------------------------------
>
> Key: HIVE-25362
> URL: https://issues.apache.org/jira/browse/HIVE-25362
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-24914 introduced a short-circuit optimization when all nodes are busy
> returning DELAYED_RESOURCES and reseting locality delay for a given tasks.
> However, this may prevent tasks from adjusting their locality delay and being
> added to the DelayQueue leading sometimes to missed locality chances when all
> LLap resources are fully utilized.
> To address the issue we should handle the two cases separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
