[
https://issues.apache.org/jira/browse/HIVE-25362?focusedWorklogId=626184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626184
]
ASF GitHub Bot logged work on HIVE-25362:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/21 15:22
Start Date: 21/Jul/21 15:22
Worklog Time Spent: 10m
Work Description: pgaref opened a new pull request #2513:
URL: https://github.com/apache/hive/pull/2513
Change-Id: Ib2d91faf4ee6d1bd839953f97ef7f7d2a00ef65f
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
HIVE-24914 introduced a short-circuit optimization when all nodes are busy
returning DELAYED_RESOURCES and reseting locality delay for a given tasks.
However, this may prevent tasks from adjusting their locality delay and
being added to the DelayQueue leading sometimes to missed locality chances when
all LLap resources are fully utilized.
Handle the two cases separately.
### Why are the changes needed?
Improve locality in Llap scheduler
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
TestLlapTaskSchedulerService#testAdjustLocalityDelay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626184)
Remaining Estimate: 0h
Time Spent: 10m
> LLAP: ensure tasks with locality have a chance to adjust delay
> --------------------------------------------------------------
>
> Key: HIVE-25362
> URL: https://issues.apache.org/jira/browse/HIVE-25362
> Project: Hive
> Issue Type: Sub-task
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HIVE-24914 introduced a short-circuit optimization when all nodes are busy
> returning DELAYED_RESOURCES and reseting locality delay for a given tasks.
> However, this may prevent tasks from adjusting their locality delay and being
> added to the DelayQueue leading sometimes to missed locality chances when all
> LLap resources are fully utilized.
> To address the issue we should handle the two cases separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
