[
https://issues.apache.org/jira/browse/HIVE-25152?focusedWorklogId=600803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600803
]
ASF GitHub Bot logged work on HIVE-25152:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/21 10:00
Start Date: 22/May/21 10:00
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637383222
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java
##########
@@ -137,10 +134,8 @@ public void closeOp(boolean abort) throws HiveException {
InputInitializerEvent.create(vertexName, inputName,
ByteBuffer.wrap(payload, 0, payload.length));
- if (LOG.isInfoEnabled()) {
- LOG.info("Sending Tez event to vertex = " + vertexName + ", input = "
+ inputName
- + ". Payload size = " + payload.length);
- }
+ LOG.info("Sending Tez event to vertex = " + vertexName + ", input = " +
inputName + ". Payload size = "
Review comment:
same
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
##########
@@ -391,9 +391,7 @@ protected void initializeOp(Configuration hconf) throws
HiveException {
}
}
- if (LOG.isInfoEnabled()) {
- LOG.info("JOIN " + outputObjInspector.getTypeName() + " totalsz = " +
totalSz);
- }
+ LOG.info("JOIN " + outputObjInspector.getTypeName() + " totalsz = " +
totalSz);
Review comment:
same
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java
##########
@@ -185,10 +185,7 @@ protected void initializeOp(Configuration hconf) throws
HiveException {
}
newChildOperatorsTag[i] = toArray(childOperatorTags);
}
- if (LOG.isInfoEnabled()) {
- LOG.info("newChildOperatorsTag " +
Arrays.toString(newChildOperatorsTag));
- }
-
+ LOG.info("newChildOperatorsTag " + Arrays.toString(newChildOperatorsTag));
Review comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 600803)
Time Spent: 2h 20m (was: 2h 10m)
> Remove Superfluous Logging Code
> -------------------------------
>
> Key: HIVE-25152
> URL: https://issues.apache.org/jira/browse/HIVE-25152
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> So much logging code can be removed to lessen the amount of code in the
> project (and perhaps some small performance gains).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
