[
https://issues.apache.org/jira/browse/HIVE-25152?focusedWorklogId=600797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600797
]
ASF GitHub Bot logged work on HIVE-25152:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/21 09:57
Start Date: 22/May/21 09:57
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637382961
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MemoryDecider.java
##########
@@ -197,9 +197,7 @@ public int compare(MapJoinOperator mj1, MapJoinOperator
mj2) {
}
if (size < remainingSize) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Setting " + size + " bytes needed for " + mj + "
(in-mem)");
- }
+ LOG.info("Setting " + size + " bytes needed for " + mj + "
(in-mem)");
Review comment:
same
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MemoryDecider.java
##########
@@ -226,23 +224,17 @@ public int compare(MapJoinOperator mj1, MapJoinOperator
mj2) {
for (MapJoinOperator mj : sortedMapJoins) {
long size = (long)(weight * sizes.get(mj));
- if (LOG.isInfoEnabled()) {
- LOG.info("Setting " + size + " bytes needed for " + mj + "
(spills)");
- }
+ LOG.info("Setting " + size + " bytes needed for " + mj + "
(spills)");
Review comment:
same
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MemoryDecider.java
##########
@@ -226,23 +224,17 @@ public int compare(MapJoinOperator mj1, MapJoinOperator
mj2) {
for (MapJoinOperator mj : sortedMapJoins) {
long size = (long)(weight * sizes.get(mj));
- if (LOG.isInfoEnabled()) {
- LOG.info("Setting " + size + " bytes needed for " + mj + "
(spills)");
- }
+ LOG.info("Setting " + size + " bytes needed for " + mj + "
(spills)");
mj.getConf().setMemoryNeeded(size);
}
} catch (HiveException e) {
// if we have issues with stats, just scale linearily
long size = totalAvailableMemory / mapJoins.size();
- if (LOG.isInfoEnabled()) {
- LOG.info("Scaling mapjoin memory w/o stats");
- }
+ LOG.info("Scaling mapjoin memory w/o stats");
for (MapJoinOperator mj : mapJoins) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Setting " + size + " bytes needed for " + mj + "
(fallback)");
- }
+ LOG.info("Setting " + size + " bytes needed for " + mj + "
(fallback)");
Review comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 600797)
Time Spent: 1h 20m (was: 1h 10m)
> Remove Superfluous Logging Code
> -------------------------------
>
> Key: HIVE-25152
> URL: https://issues.apache.org/jira/browse/HIVE-25152
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> So much logging code can be removed to lessen the amount of code in the
> project (and perhaps some small performance gains).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
