[
https://issues.apache.org/jira/browse/HIVE-25064?focusedWorklogId=590310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590310
]
ASF GitHub Bot logged work on HIVE-25064:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/21 11:39
Start Date: 28/Apr/21 11:39
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2226:
URL: https://github.com/apache/hive/pull/2226#discussion_r622091894
##########
File path: iceberg/iceberg-shading/pom.xml
##########
@@ -0,0 +1,147 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-iceberg</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>hive-iceberg-shading</artifactId>
+ <packaging>jar</packaging>
+ <name>Hive Iceberg Shading</name>
+ <description>
+ This module collects all required Iceberg modules and their
dependencies, and shades them.
+ Consuming modules only need to mark this module as their dependency to
get any required Iceberg libs.
+ This module has no sources of its own, only the built jar file
contains the gathered and shaded libs.
+ For Intellij this module is recommended to be ignored, to avoid the
dependent modules considering this as a
+ module dependency, they should see this as a library dependency
instead.
+ </description>
+
+ <properties>
+ <hive.path.to.root>../..</hive.path.to.root>
+ <path.to.iceberg.root>..</path.to.iceberg.root>
+
<shade.relocation.package.prefix>org.apache.hive.iceberg</shade.relocation.package.prefix>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>patched-iceberg-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-data</artifactId>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-parquet</artifactId>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-orc</artifactId>
+ <optional>true</optional>
+ </dependency>
+ </dependencies>
+
+ <profiles>
+ <profile>
+ <id>shaded-build</id>
+ <activation>
+ <property>
+ <name>skipShade</name>
+ <value>!true</value>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+
<createDependencyReducedPom>false</createDependencyReducedPom>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.org.apache.avro</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.orc</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.org.apache.orc</shadedPattern>
+ </relocation>
+ <relocation>
+
<pattern>org.apache.parquet</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.org.apache.parquet</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>shaded.parquet</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.shaded.parquet</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.fasterxml</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.com.fasterxml</shadedPattern>
+ </relocation>
+ <relocation>
+
<pattern>com.github.benmanes</pattern>
+
<shadedPattern>${shade.relocation.package.prefix}.com.github.benmanes</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <includes>
+
<include>org.apache.iceberg:*</include>
+
<include>org.apache.hive:hive-iceberg-catalog</include>
Review comment:
if the catalog module depends on the shading module, isn't it a problem
that the shading module's shade step depends on the catalog? Is this some form
of a circular dependency? Maybe not, just checking :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 590310)
Time Spent: 1h 10m (was: 1h)
> Create separate shader maven module for Iceberg libraries
> ---------------------------------------------------------
>
> Key: HIVE-25064
> URL: https://issues.apache.org/jira/browse/HIVE-25064
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
