[
https://issues.apache.org/jira/browse/HIVE-25064?focusedWorklogId=590309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590309
]
ASF GitHub Bot logged work on HIVE-25064:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/21 11:37
Start Date: 28/Apr/21 11:37
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2226:
URL: https://github.com/apache/hive/pull/2226#discussion_r622090465
##########
File path: iceberg/pom.xml
##########
@@ -51,14 +52,24 @@
<dependencies>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-api</artifactId>
+ <artifactId>patched-iceberg-api</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-core</artifactId>
+ <artifactId>patched-iceberg-core</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ <version>${iceberg-api.version}</version>
Review comment:
not completely related to this PR, but why isn't this just
`iceberg.version`? I guess there shouldn't be different version for
iceberg-api, iceberg-data, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 590309)
Time Spent: 1h (was: 50m)
> Create separate shader maven module for Iceberg libraries
> ---------------------------------------------------------
>
> Key: HIVE-25064
> URL: https://issues.apache.org/jira/browse/HIVE-25064
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
