[ 
https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=590110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590110
 ]

ASF GitHub Bot logged work on HIVE-24909:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Apr/21 02:04
            Start Date: 28/Apr/21 02:04
    Worklog Time Spent: 10m 
      Work Description: hmangla98 commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r621754207



##########
File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -1645,15 +1644,20 @@ public void testHdfsMaxDirItemsLimitDuringIncremental() 
throws Throwable {
     WarehouseInstance.Tuple incrementalDump2 = primary.run("use " + 
primaryDbName)
             .dump(primaryDbName, dumpClause);
 
-    eventCount = Integer.parseInt(incrementalDump2.lastReplicationId)
-            - Integer.parseInt(incrementalDump1.lastReplicationId);
-    assertTrue(eventCount > 5);
+    eventCount = getNoOfEventsDumped(incrementalDump2.dumpLocation);
+    assertTrue(eventCount > 5 && eventCount < 1000);

Review comment:
       This test is to assert that no of events dumped cannot be greater than 
(DFS_MAX_DIR_ITEMS_CONFIG - RESERVED_DIR_ITEMS_COUNT). For this particular run 
of repl dump (line no. 1645), This value is 1000 which was initially 5 for the 
previous run. So, no of events should be greater than 5 and less than 1000.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 590110)
    Time Spent: 6h 40m  (was: 6.5h)

> Skip the repl events from getting logged in notification log
> ------------------------------------------------------------
>
>                 Key: HIVE-24909
>                 URL: https://issues.apache.org/jira/browse/HIVE-24909
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Haymant Mangla
>            Assignee: Haymant Mangla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> Currently REPL dump events are logged and replicated as a part of replication 
> policy. Whenever one replication cycle completed, we always have one 
> transaction left open on the target corresponding to repl dump operation. 
> This will never be caught up without manually dealing with the transaction on 
> target cluster.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to