[
https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=585509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585509
]
ASF GitHub Bot logged work on HIVE-24909:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 01:30
Start Date: 20/Apr/21 01:30
Worklog Time Spent: 10m
Work Description: hmangla98 commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r616280662
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -8582,7 +8582,8 @@ public GetOpenTxnsInfoResponse get_open_txns_info()
throws TException {
public OpenTxnsResponse open_txns(OpenTxnRequest rqst) throws TException {
OpenTxnsResponse response = getTxnHandler().openTxns(rqst);
List<Long> txnIds = response.getTxn_ids();
- if (txnIds != null && listeners != null && !listeners.isEmpty()) {
+ boolean isHiveReplTxn = rqst.isSetReplPolicy() && rqst.getTxn_type() ==
TxnType.DEFAULT;
Review comment:
rqst variable can be of different types (OpenTxnRequest/
CommitTxnRequest/ AbortTxnRequest). So, this statement may not be generalised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 585509)
Time Spent: 5h 20m (was: 5h 10m)
> Skip the repl events from getting logged in notification log
> ------------------------------------------------------------
>
> Key: HIVE-24909
> URL: https://issues.apache.org/jira/browse/HIVE-24909
> Project: Hive
> Issue Type: Bug
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Currently REPL dump events are logged and replicated as a part of replication
> policy. Whenever one replication cycle completed, we always have one
> transaction left open on the target corresponding to repl dump operation.
> This will never be caught up without manually dealing with the transaction on
> target cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
