[ 
https://issues.apache.org/jira/browse/HIVE-25057?focusedWorklogId=589243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589243
 ]

ASF GitHub Bot logged work on HIVE-25057:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Apr/21 13:34
            Start Date: 26/Apr/21 13:34
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on a change in pull request #2219:
URL: https://github.com/apache/hive/pull/2219#discussion_r620274616



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -159,11 +162,16 @@ public void 
commitCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTabl
 
   @Override
   public void preDropTable(org.apache.hadoop.hive.metastore.api.Table 
hmsTable) {
+    // do nothing

Review comment:
       When does this version of the hook get called (vs the one with 
deleteData param)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 589243)
    Time Spent: 3h 40m  (was: 3.5h)

> Implement rollback for hive to iceberg migration
> ------------------------------------------------
>
>                 Key: HIVE-25057
>                 URL: https://issues.apache.org/jira/browse/HIVE-25057
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> This is a follow-up Jira of HIVE-25008.
> In case of an error during hive to iceberg migration, the original hive table 
> must be restored. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to