[
https://issues.apache.org/jira/browse/HIVE-25057?focusedWorklogId=589232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589232
]
ASF GitHub Bot logged work on HIVE-25057:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/21 13:07
Start Date: 26/Apr/21 13:07
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2219:
URL: https://github.com/apache/hive/pull/2219#discussion_r620278440
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -955,4 +1046,44 @@ private void validateBasicStats(Table icebergTable,
String dbName, String tableN
Assert.assertEquals(summary.get(entry.getValue()),
hmsParams.get(entry.getKey()));
}
}
+
+ private void validateMigration(String tableName, int recordCount) {
+ List<Object[]> originalResult = shell.executeStatement("SELECT * FROM " +
tableName + " ORDER BY a");
+ Assert.assertEquals(recordCount, originalResult.size());
+ List<Object[]> originalDescribe = shell.executeStatement("DESCRIBE
FORMATTED " + tableName);
+ validateDescribeOutput(originalDescribe, fileFormat.name());
Review comment:
I'm not sure we need this, since this is only checking hive behaviour,
not iceberg
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -955,4 +1046,44 @@ private void validateBasicStats(Table icebergTable,
String dbName, String tableN
Assert.assertEquals(summary.get(entry.getValue()),
hmsParams.get(entry.getKey()));
}
}
+
+ private void validateMigration(String tableName, int recordCount) {
+ List<Object[]> originalResult = shell.executeStatement("SELECT * FROM " +
tableName + " ORDER BY a");
+ Assert.assertEquals(recordCount, originalResult.size());
+ List<Object[]> originalDescribe = shell.executeStatement("DESCRIBE
FORMATTED " + tableName);
+ validateDescribeOutput(originalDescribe, fileFormat.name());
Review comment:
I'm not sure we need this, since this is only checking hive behaviour,
not iceberg. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 589232)
Time Spent: 2h 20m (was: 2h 10m)
> Implement rollback for hive to iceberg migration
> ------------------------------------------------
>
> Key: HIVE-25057
> URL: https://issues.apache.org/jira/browse/HIVE-25057
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This is a follow-up Jira of HIVE-25008.
> In case of an error during hive to iceberg migration, the original hive table
> must be restored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
