[
https://issues.apache.org/jira/browse/HIVE-25001?focusedWorklogId=580910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580910
]
ASF GitHub Bot logged work on HIVE-25001:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/21 12:01
Start Date: 12/Apr/21 12:01
Worklog Time Spent: 10m
Work Description: coder-chenzhi commented on pull request #2165:
URL: https://github.com/apache/hive/pull/2165#issuecomment-817751913
Thanks, @pgaref . I added one comment before the declaration of
`requestedHostsDebugStr`. And I think we do not need to retrigger Tests because
the patch is simple and just touched some logging code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 580910)
Time Spent: 40m (was: 0.5h)
> Improvement for some debug-logging guards
> -----------------------------------------
>
> Key: HIVE-25001
> URL: https://issues.apache.org/jira/browse/HIVE-25001
> Project: Hive
> Issue Type: Improvement
> Reporter: Chen Zhi
> Priority: Minor
> Labels: pull-request-available
> Attachments: HIVE-25001.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Moving some potential expensive statements (e.g. `Arrays.toString`) into the
> adjacent logging guards, since these statements are merely used by the
> following logging calls.
> Note that the fix in `LlapTaskSchedulerService.java` is different with other
> cases in this patch, because the variable `requestedHostsDebugStr` is used by
> several debug-logging calls, and we have to declare and assign the variable
> before these debug-logging calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
