[
https://issues.apache.org/jira/browse/HIVE-25001?focusedWorklogId=580636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580636
]
ASF GitHub Bot logged work on HIVE-25001:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/21 02:20
Start Date: 11/Apr/21 02:20
Worklog Time Spent: 10m
Work Description: coder-chenzhi opened a new pull request #2165:
URL: https://github.com/apache/hive/pull/2165
### What changes were proposed in this pull request?
Moving some potential expensive statements (e.g. `Arrays.toString`) into the
adjacent logging guards, since these statements are merely used by the
following logging calls.
Note that the fix in `LlapTaskSchedulerService.java` is different with other
cases in this patch, because the variable `requestedHostsDebugStr` is used by
several debug-logging calls, and we have to declare and assign the variable
before these debug-logging calls.
### Why are the changes needed?
Minor (performance) improvement to logging code
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Minor improvement to logging code, and no need to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 580636)
Remaining Estimate: 0h
Time Spent: 10m
> Improvement for some debug-logging guards
> -----------------------------------------
>
> Key: HIVE-25001
> URL: https://issues.apache.org/jira/browse/HIVE-25001
> Project: Hive
> Issue Type: Improvement
> Reporter: Chen Zhi
> Priority: Minor
> Attachments: HIVE-25001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Moving some potential expensive statements (e.g. `Arrays.toString`) into the
> adjacent logging guards, since these statements are merely used by the
> following logging calls.
> Note that the fix in `LlapTaskSchedulerService.java` is different with other
> cases in this patch, because the variable `requestedHostsDebugStr` is used by
> several debug-logging calls, and we have to declare and assign the variable
> before these debug-logging calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
