[
https://issues.apache.org/jira/browse/HIVE-24962?focusedWorklogId=579040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579040
]
ASF GitHub Bot logged work on HIVE-24962:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/21 09:44
Start Date: 08/Apr/21 09:44
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2137:
URL: https://github.com/apache/hive/pull/2137#discussion_r609515251
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -250,4 +298,74 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
// this is an exception to the interface documentation, but it's a safe
operation to add this property
props.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
}
+
+ /**
+ * Recursively collects the column names from the predicate.
+ * @param node The node we are traversing
+ * @param columns The already collected column names
+ */
+ private void columns(ExprNodeDesc node, Collection<String> columns) {
+ if (node instanceof ExprNodeColumnDesc) {
+ columns.add(((ExprNodeColumnDesc) node).getColumn());
+ } else {
+ List<ExprNodeDesc> children = node.getChildren();
+ if (children != null && !children.isEmpty()) {
+ children.forEach(child -> columns(child, columns));
+ }
+ }
+ }
+
+ /**
+ * Recursively replaces the ExprNodeDynamicListDesc nodes by a dummy
ExprNodeConstantDesc so we can test if we can
+ * convert the predicate to an Iceberg predicate when pruning the partitions
later. Please make sure that it is ok
Review comment:
I'm not entirely sure I understand why this dummy replacement is needed
to convert the predicate to an Iceberg predicate. Can you elaborate a little
bit (maybe in the javadoc too)? Apologies if it's obvious, I'm just not that
knowledgeable on partition pruning & co. and I'm assuming some of the future
maintainers of this code might not be either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 579040)
Time Spent: 1h 40m (was: 1.5h)
> Enable partition pruning for Iceberg tables
> -------------------------------------------
>
> Key: HIVE-24962
> URL: https://issues.apache.org/jira/browse/HIVE-24962
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We should enable partition pruning above iceberg tables
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
