[
https://issues.apache.org/jira/browse/HIVE-24962?focusedWorklogId=579026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579026
]
ASF GitHub Bot logged work on HIVE-24962:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/21 09:21
Start Date: 08/Apr/21 09:21
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2137:
URL: https://github.com/apache/hive/pull/2137#discussion_r609494843
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -153,6 +168,39 @@ public DecomposedPredicate decomposePredicate(JobConf
jobConf, Deserializer dese
return predicate;
}
+ @Override
+ public boolean
addDynamicSplitPruningEdge(org.apache.hadoop.hive.ql.metadata.Table table,
+ ExprNodeDesc syntheticFilterPredicate) {
+ try {
+ Collection<String> partitionColumns = ((HiveIcebergSerDe)
table.getDeserializer()).partitionColumns();
+ if (partitionColumns.size() > 0) {
+ // Collect the column names from the predicate
+ Collection<String> filterColumns = Lists.newArrayList();
+ columns(syntheticFilterPredicate, filterColumns);
+
+ if (filterColumns.removeAll(partitionColumns)) {
Review comment:
IIUC the intention here is to enter this block if the filter columns
contain any partition columns. Instead of using `removeAll`, would it be more
descriptive to do something like this?
```
boolean filterContainsPartitionCols = filterColumns.stream().anyMatch(...);
if (filterContainsPartitionCols) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 579026)
Time Spent: 40m (was: 0.5h)
> Enable partition pruning for Iceberg tables
> -------------------------------------------
>
> Key: HIVE-24962
> URL: https://issues.apache.org/jira/browse/HIVE-24962
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We should enable partition pruning above iceberg tables
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
