[jira] [Work logged] (HIVE-24955) New metrics about aborted transactions

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-24955?focusedWorklogId=575374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575374
 ]

ASF GitHub Bot logged work on HIVE-24955:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/21 07:59
            Start Date: 01/Apr/21 07:59
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on a change in pull request #2132:
URL: https://github.com/apache/hive/pull/2132#discussion_r605452311



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -4579,13 +4585,16 @@ private int abortTxns(Connection dbConn, List<Long> 
txnids, boolean checkHeartbe
       TxnUtils.buildQueryWithINClause(conf, queries, prefix, suffix, txnids, 
"\"HL_TXNID\"", false, false);
 
       // execute all queries in the list in one batch
+      int numAborted = 0;
       if (skipCount) {

Review comment:
       When we abort a single txn, skipCount=true, so we might get very 
inaccurate values here. Probably we should return count in 
abortTxn(AbortTxnRequest rqst) as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 575374)
    Time Spent: 2h  (was: 1h 50m)

> New metrics about aborted transactions
> --------------------------------------
>
>                 Key: HIVE-24955
>                 URL: https://issues.apache.org/jira/browse/HIVE-24955
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> 5 new metrics:
>  * Number of aborted transactions in the TXNS table (collected in 
> AcidMetricsService)
>  * Oldest aborted transaction (collected in AcidMetricsService)
>  * Number of aborted write transaction (incremented counter at 
> abortTransaction)
>  * Number of committed write transaction (incremented counter at 
> commitTransaction)
>  * Number of timed out transactions (cleaner removed them after heartbeat 
> time out)
> The latter 3 will restart as 0 after every HMS restart 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)