[
https://issues.apache.org/jira/browse/HIVE-24955?focusedWorklogId=574132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574132
]
ASF GitHub Bot logged work on HIVE-24955:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 12:46
Start Date: 30/Mar/21 12:46
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2132:
URL: https://github.com/apache/hive/pull/2132#discussion_r604062554
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/MetricsConstants.java
##########
@@ -27,6 +27,11 @@
public static final String COMPACTION_WORKER_CYCLE =
"compaction_worker_cycle";
public static final String OLDEST_OPEN_TXN_ID = "oldest_open_txn_id";
public static final String OLDEST_OPEN_TXN_AGE =
"oldest_open_txn_age_in_sec";
+ // number of aborted txns in TXNS table
+ public static final String NUM_ABORTED_TXNS_IN_TXNS =
COMPACTION_STATUS_PREFIX + "aborted_txns_in_txns";
Review comment:
I have to differentiate between 2 metrics:
1. count in TXNs where status='a' (current name: NUM_ABORTED_TXNS_IN_TXNS)
2. total number of aborted txns since hms was started (current name:
NUM_ABORTED_WRITE_TXNS but I'd change this to NUM_ABORTED_TXNS)
It would also make sense to change #2 to NUM_TOTAL_ABORTED_TXNS and #1 to
NUM_CURRENT_ABORTED_TXNS. Does that make sense to you too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 574132)
Time Spent: 1.5h (was: 1h 20m)
> New metrics about aborted transactions
> --------------------------------------
>
> Key: HIVE-24955
> URL: https://issues.apache.org/jira/browse/HIVE-24955
> Project: Hive
> Issue Type: Sub-task
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> 5 new metrics:
> * Number of aborted transactions in the TXNS table (collected in
> AcidMetricsService)
> * Oldest aborted transaction (collected in AcidMetricsService)
> * Number of aborted write transaction (incremented counter at
> abortTransaction)
> * Number of committed write transaction (incremented counter at
> commitTransaction)
> * Number of timed out transactions (cleaner removed them after heartbeat
> time out)
> The latter 3 will restart as 0 after every HMS restartÂ
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
