[
https://issues.apache.org/jira/browse/HIVE-24855?focusedWorklogId=570620&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570620
]
ASF GitHub Bot logged work on HIVE-24855:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 16:29
Start Date: 23/Mar/21 16:29
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #2046:
URL: https://github.com/apache/hive/pull/2046#discussion_r599733588
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java
##########
@@ -182,11 +190,11 @@ static VectorizedRowBatchCtx createFakeVrbCtx(MapWork
mapWork) throws HiveExcept
RowSchema rowSchema = findTsOp(mapWork).getSchema();
final List<String> colNames = new
ArrayList<String>(rowSchema.getSignature().size());
final List<TypeInfo> colTypes = new
ArrayList<TypeInfo>(rowSchema.getSignature().size());
- boolean hasRowId = false;
+ ArrayList<VirtualColumn> virtualColumnList = new ArrayList<>(2);
for (ColumnInfo c : rowSchema.getSignature()) {
String columnName = c.getInternalName();
- if (VirtualColumn.ROWID.getName().equals(columnName)) {
- hasRowId = true;
+ if (ALLOWED_VIRTUAL_COLUMNS.containsKey(columnName)) {
+ virtualColumnList.add(ALLOWED_VIRTUAL_COLUMNS.get(columnName));
} else {
if (VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(columnName)) continue;
Review comment:
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 570620)
Time Spent: 1h 10m (was: 1h)
> Introduce virtual colum ROW__IS__DELETED
> ----------------------------------------
>
> Key: HIVE-24855
> URL: https://issues.apache.org/jira/browse/HIVE-24855
> Project: Hive
> Issue Type: New Feature
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
