[ 
https://issues.apache.org/jira/browse/HIVE-24855?focusedWorklogId=570315&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570315
 ]

ASF GitHub Bot logged work on HIVE-24855:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Mar/21 09:19
            Start Date: 23/Mar/21 09:19
    Worklog Time Spent: 10m 
      Work Description: kasakrisz commented on a change in pull request #2046:
URL: https://github.com/apache/hive/pull/2046#discussion_r599394313



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -1970,8 +1970,22 @@ private int processQueryHint(ASTNode ast, QBParseInfo 
qbp, int posn) throws Sema
     String queryHintStr = ast.getText();
     LOG.debug("QUERY HINT: {} ", queryHintStr);
     try {
-      ASTNode hintNode = pd.parseHint(queryHintStr);
-      qbp.setHints(hintNode);
+      ASTNode hintListNode = pd.parseHint(queryHintStr);
+      qbp.setHints(hintListNode);
+      for (int i = 0; i < hintListNode.getChildCount(); ++i) {
+        ASTNode hintNode = (ASTNode) hintListNode.getChild(i);
+        if (hintNode.getChild(0).getType() != 
HintParser.TOK_FETCH_DELETED_ROWS) {

Review comment:
       Removed hint. Using `acid.fetch.deleted.rows` as table property.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 570315)
    Time Spent: 40m  (was: 0.5h)

> Introduce virtual colum ROW__IS__DELETED
> ----------------------------------------
>
>                 Key: HIVE-24855
>                 URL: https://issues.apache.org/jira/browse/HIVE-24855
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to