[
https://issues.apache.org/jira/browse/HIVE-24778?focusedWorklogId=560513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560513
]
ASF GitHub Bot logged work on HIVE-24778:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/21 15:18
Start Date: 03/Mar/21 15:18
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #1982:
URL: https://github.com/apache/hive/pull/1982#discussion_r586504261
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/TimestampCastRestrictorResolver.java
##########
@@ -45,7 +45,7 @@
public TimestampCastRestrictorResolver(UDFMethodResolver parentResolver) {
this.parentResolver = parentResolver;
SessionState ss = SessionState.get();
- if (ss != null &&
ss.getConf().getBoolVar(ConfVars.HIVE_STRICT_TIMESTAMP_CONVERSION)) {
+ if (ss != null &&
ss.getConf().getBoolVar(ConfVars.HIVE_STRICT_CHECKS_TYPE_SAFETY)) {
Review comment:
Putting a note here so that we don't forget. The SQL standard forbids
all kind of explicit casts from DATE, TIME, DATETIME to non char datatypes and
does not mention anything about implicit casts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 560513)
Time Spent: 1h 10m (was: 1h)
> Unify hive.strict.timestamp.conversion and hive.strict.checks.type.safety
> properties
> ------------------------------------------------------------------------------------
>
> Key: HIVE-24778
> URL: https://issues.apache.org/jira/browse/HIVE-24778
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 4.0.0
> Reporter: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The majority of strict type checks can be controlled by
> {{hive.strict.checks.type.safety}} property. HIVE-24157 introduced another
> property, namely {{hive.strict.timestamp.conversion}}, to control the
> implicit comparisons between numerics and timestamps.
> The name and description of {{hive.strict.checks.type.safety}} imply that the
> property covers all strict checks so having others for specific cases appears
> confusing and can easily lead to unexpected behavior.
> The goal of this issue is to unify those properties to facilitate
> configuration and improve code reuse.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
