[ https://issues.apache.org/jira/browse/HIVE-24778?focusedWorklogId=552909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552909 ]
ASF GitHub Bot logged work on HIVE-24778: ----------------------------------------- Author: ASF GitHub Bot Created on: 16/Feb/21 11:34 Start Date: 16/Feb/21 11:34 Worklog Time Spent: 10m Work Description: pgaref opened a new pull request #1982: URL: https://github.com/apache/hive/pull/1982 ### What changes were proposed in this pull request? The majority of strict type checks can be controlled by hive.strict.checks.type.safety property. HIVE-24157 introduced another property, namely hive.strict.timestamp.conversion, to control the implicit comparisons between numerics and timestamps. The name and description of hive.strict.checks.type.safety imply that the property covers all strict checks so having others for specific cases appears confusing and can easily lead to unexpected behavior. This PR unifies those properties to facilitate configuration and improve code reuse. ### Why are the changes needed? Reduce conf complexity ### Does this PR introduce _any_ user-facing change? Unifies hive.strict.timestamp.conversion and hive.strict.checks.type.safety properties ### How was this patch tested? Existing tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 552909) Remaining Estimate: 0h Time Spent: 10m > Unify hive.strict.timestamp.conversion and hive.strict.checks.type.safety > properties > ------------------------------------------------------------------------------------ > > Key: HIVE-24778 > URL: https://issues.apache.org/jira/browse/HIVE-24778 > Project: Hive > Issue Type: Sub-task > Affects Versions: 4.0.0 > Reporter: Stamatis Zampetakis > Priority: Major > Fix For: 4.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The majority of strict type checks can be controlled by > {{hive.strict.checks.type.safety}} property. HIVE-24157 introduced another > property, namely {{hive.strict.timestamp.conversion}}, to control the > implicit comparisons between numerics and timestamps. > The name and description of {{hive.strict.checks.type.safety}} imply that the > property covers all strict checks so having others for specific cases appears > confusing and can easily lead to unexpected behavior. > The goal of this issue is to unify those properties to facilitate > configuration and improve code reuse. -- This message was sent by Atlassian Jira (v8.3.4#803005)