[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=544362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544362
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/21 17:08
Start Date: 29/Jan/21 17:08
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r566966893
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -4131,4 +4132,12 @@ ReplicationMetricList
getReplicationMetrics(GetReplicationMetricsRequest
void dropStoredProcedure(StoredProcedureRequest request) throws
MetaException, NoSuchObjectException, TException;
List<String> getAllStoredProcedures(ListStoredProcedureRequest request)
throws MetaException, TException;
+
+ void addPackage(Package request) throws NoSuchObjectException,
MetaException, TException;
+
+ Package findPackage(PackageRequest request) throws TException;
Review comment:
fixed
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -4131,4 +4132,12 @@ ReplicationMetricList
getReplicationMetrics(GetReplicationMetricsRequest
void dropStoredProcedure(StoredProcedureRequest request) throws
MetaException, NoSuchObjectException, TException;
List<String> getAllStoredProcedures(ListStoredProcedureRequest request)
throws MetaException, TException;
+
+ void addPackage(Package request) throws NoSuchObjectException,
MetaException, TException;
+
+ Package findPackage(PackageRequest request) throws TException;
+
+ List<String> listPackages(ListPackageRequest request) throws TException;
+
+ void dropPackage(PackageRequest request) throws TException;
Review comment:
fixed
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -10526,6 +10530,14 @@ private static void populate(StoredProcedure proc,
MDatabase mDatabase, MStoredP
result.setDatabase(mDatabase);
}
+ private static void populate(Package pkg, MDatabase mDatabase, MPackage
result) throws MetaException {
Review comment:
fixed
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -10567,6 +10587,16 @@ private StoredProcedure convertToStoredProc(String
catName, MStoredProc proc) {
proc.getSource());
}
+ private Package convertToPackage(String catName, MPackage mPkg) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 544362)
Time Spent: 4h 40m (was: 4.5h)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
