[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=544255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544255
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/21 12:41
Start Date: 29/Jan/21 12:41
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r566794345
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -1460,7 +1495,26 @@ public Integer
visitCreate_procedure_stmt(HplsqlParser.Create_procedure_stmtCont
addLocalUdf(ctx); // Add procedures as they can be
invoked by functions
return 0;
}
-
+
+ public void dropProcedure(HplsqlParser.Drop_stmtContext ctx, String name,
boolean checkIfExists) {
+ if (checkIfExists && !function.exists(name)) {
+ trace(ctx, name + " DOES NOT EXIST");
+ return;
+ }
+ function.remove(name);
Review comment:
Ok let's rename it.
Just some context: the name was inherited from the existing implementation,
I hope I can do some more refactoring after we dropped the in memory
implementations and only keep the HMS backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 544255)
Time Spent: 3h (was: 2h 50m)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
