[ 
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=542906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542906
 ]

ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/21 16:29
            Start Date: 27/Jan/21 16:29
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on pull request #1733:
URL: https://github.com/apache/hive/pull/1733#issuecomment-768406372


   @mustafaiman, thanks for the review.
   
   get_all_stored_procedures is used drop_package is used in 
HiveMetaStore>>drop_database_core() when dropping a DB. Without removing the 
packages first the DB drop would fail with FK key violation.
   
   Regarding the InMemoryPackageRegistry/Package hashmap thing I have to think 
about it. Right now it doesn't look interchangeable to me. The package registry 
contains the source code while the hashmap in exec contains the parsed 
structure. 
   
   I agree with the doing the uppercase conversion should take place at the 
boundary once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 542906)
    Time Spent: 1h  (was: 50m)

> Store HPL/SQL packages into HMS
> -------------------------------
>
>                 Key: HIVE-24346
>                 URL: https://issues.apache.org/jira/browse/HIVE-24346
>             Project: Hive
>          Issue Type: Sub-task
>          Components: hpl/sql, Metastore
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to