[ https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=542896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542896 ]
ASF GitHub Bot logged work on HIVE-24346: ----------------------------------------- Author: ASF GitHub Bot Created on: 27/Jan/21 15:50 Start Date: 27/Jan/21 15:50 Worklog Time Spent: 10m Work Description: zeroflag commented on a change in pull request #1733: URL: https://github.com/apache/hive/pull/1733#discussion_r565420580 ########## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ########## @@ -2856,6 +2876,11 @@ PartitionsResponse get_partitions_req(1:PartitionsRequest req) StoredProcedure get_stored_procedure(1: StoredProcedureRequest request) throws (1:MetaException o1, 2:NoSuchObjectException o2) void drop_stored_procedure(1: StoredProcedureRequest request) throws (1:MetaException o1, 2:NoSuchObjectException o2) list<string> get_all_stored_procedures(1: ListStoredProcedureRequest request) throws (1:MetaException o1) + + Package find_package(1: PackageRequest request) throws (1:MetaException o1) Review comment: This was requested in an earlier review to follow this convention at every thrift method. The rational behind it is that it allows making compatible changes (adding new fields into PackageRequest) easier without touching the signature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 542896) Time Spent: 50m (was: 40m) > Store HPL/SQL packages into HMS > ------------------------------- > > Key: HIVE-24346 > URL: https://issues.apache.org/jira/browse/HIVE-24346 > Project: Hive > Issue Type: Sub-task > Components: hpl/sql, Metastore > Reporter: Attila Magyar > Assignee: Attila Magyar > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)