[
https://issues.apache.org/jira/browse/HIVE-24329?focusedWorklogId=512333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512333
]
ASF GitHub Bot logged work on HIVE-24329:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/20 12:57
Start Date: 16/Nov/20 12:57
Worklog Time Spent: 10m
Work Description: pvargacl commented on a change in pull request #1647:
URL: https://github.com/apache/hive/pull/1647#discussion_r524248581
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -8373,6 +8374,11 @@ public void commit_txn(CommitTxnRequest rqst) throws
TException {
if (listeners != null && !listeners.isEmpty()) {
MetaStoreListenerNotifier.notifyEvent(listeners, EventType.COMMIT_TXN,
new CommitTxnEvent(rqst.getTxnid(), this));
+ CompactionInfo compactionInfo =
getTxnHandler().getCompactionByTxnId(rqst.getTxnid());
Review comment:
This does a little bit different thing. In TxnHandler we notify the
transactional eventListeners using the same jdbc connection from the
txnhandler. The event will be committed together with the "hive transaction
commit". This on the other hand notifies the "normal" event listeners. The file
metadata cache strictly needs only the first one, but every other transactional
event is fired as normal event also, so I don't want to break this pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 512333)
Time Spent: 2h 20m (was: 2h 10m)
> Add HMS notification for compaction commit
> ------------------------------------------
>
> Key: HIVE-24329
> URL: https://issues.apache.org/jira/browse/HIVE-24329
> Project: Hive
> Issue Type: New Feature
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This could be used by file metadata caches, to invalidate the cache content
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
