[
https://issues.apache.org/jira/browse/HIVE-24329?focusedWorklogId=510264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510264
]
ASF GitHub Bot logged work on HIVE-24329:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/20 14:15
Start Date: 11/Nov/20 14:15
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #1647:
URL: https://github.com/apache/hive/pull/1647#discussion_r521386568
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1409,6 +1407,23 @@ public void commitTxn(CommitTxnRequest rqst)
}
}
+ /**
+ * Create Notifiaction Events on txn commit
+ * @param dbConn DatabaseConnection
+ * @param txnid committed txn
+ * @param txnType transaction type
+ * @throws MetaException ex
+ */
+ protected void createCommitNotificationEvent(Connection dbConn, long txnid,
Optional<TxnType> txnType)
+ throws MetaException, SQLException {
+ if (transactionalListeners != null) {
+
MetaStoreListenerNotifier.notifyEventWithDirectSql(transactionalListeners,
+ EventMessage.EventType.COMMIT_TXN, new CommitTxnEvent(txnid,
txnType.get()), dbConn, sqlGenerator);
+ }
+ }
+
+ protected abstract CompactionInfo getCompactionByTxnId(Connection dbConn,
long txnid) throws SQLException, MetaException;
Review comment:
why do we have compaction related stuff in TxnHandler?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 510264)
Time Spent: 1h (was: 50m)
> Add HMS notification for compaction commit
> ------------------------------------------
>
> Key: HIVE-24329
> URL: https://issues.apache.org/jira/browse/HIVE-24329
> Project: Hive
> Issue Type: New Feature
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This could be used by file metadata caches, to invalidate the cache content
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
