[jira] [Work logged] (HIVE-24333) Cut long methods in Driver to smaller, more manageable pieces

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-24333?focusedWorklogId=509865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509865
 ]

ASF GitHub Bot logged work on HIVE-24333:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Nov/20 18:19
            Start Date: 10/Nov/20 18:19
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on a change in pull request 
#1629:
URL: https://github.com/apache/hive/pull/1629#discussion_r520773191



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -638,46 +654,28 @@ public boolean getResults(List results) throws 
IOException {
     }
 
     if (isFetchingTable()) {
-      /**
-       * If resultset serialization to thrift object is enabled, and if the 
destination table is
-       * indeed written using ThriftJDBCBinarySerDe, read one row from the 
output sequence file,
-       * since it is a blob of row batches.
-       */
-      if 
(driverContext.getFetchTask().getWork().isUsingThriftJDBCBinarySerDe()) {
-        maxRows = 1;
-      }
-      driverContext.getFetchTask().setMaxRows(maxRows);
-      return driverContext.getFetchTask().fetch(results);
+      return getFetchingTableResults(results);
     }
 
     if (driverContext.getResStream() == null) {
       driverContext.setResStream(context.getStream());
-    }
-    if (driverContext.getResStream() == null) {
-      return false;
+      if (driverContext.getResStream() == null) {
+        return false;
+      }
     }

Review comment:
       I agree, it's nicer like this, fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 509865)
    Time Spent: 2h 40m  (was: 2.5h)

> Cut long methods in Driver to smaller, more manageable pieces
> -------------------------------------------------------------
>
>                 Key: HIVE-24333
>                 URL: https://issues.apache.org/jira/browse/HIVE-24333
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Some methods in Driver are too long to be easily understandable. They should 
> be cut into pieces to make them easier to understand.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)