[
https://issues.apache.org/jira/browse/HIVE-24333?focusedWorklogId=509860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509860
]
ASF GitHub Bot logged work on HIVE-24333:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/20 18:17
Start Date: 10/Nov/20 18:17
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1629:
URL: https://github.com/apache/hive/pull/1629#discussion_r520772082
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java
##########
@@ -73,7 +73,7 @@ private static IReExecutionPlugin buildReExecPlugin(String
name) throws RuntimeE
if("reexecute_lost_am".equals(name)) {
return new ReExecuteLostAMQueryPlugin();
}
- if (name.equals("dagsubmit")) {
+ if ("dagsubmit".equals(name)) {
Review comment:
OK, removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 509860)
Time Spent: 2h (was: 1h 50m)
> Cut long methods in Driver to smaller, more manageable pieces
> -------------------------------------------------------------
>
> Key: HIVE-24333
> URL: https://issues.apache.org/jira/browse/HIVE-24333
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Some methods in Driver are too long to be easily understandable. They should
> be cut into pieces to make them easier to understand.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
