[ 
https://issues.apache.org/jira/browse/HIVE-23031?focusedWorklogId=429094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429094
 ]

ASF GitHub Bot logged work on HIVE-23031:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Apr/20 15:44
            Start Date: 30/Apr/20 15:44
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #988:
URL: https://github.com/apache/hive/pull/988#discussion_r418107419



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -2465,6 +2465,19 @@ private static void 
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "If the number of references to a CTE clause exceeds this threshold, 
Hive will materialize it\n" +
         "before executing the main query block. -1 will disable this 
feature."),
 
+    HIVE_OPTIMIZE_BI_ENABLED("hive.optimize.bi.enabled", false,
+        "Enables query rewrites based on approximate functions(sketches)."),
+
+    
HIVE_OPTIMIZE_BI_REWRITE_COUNTDISTINCT_ENABLED("hive.optimize.bi.rewrite.countdistinct.enabled",
+        true,
+        "Enables to rewrite COUNT(DISTINCT(X)) queries to be rewritten to use 
sketch functions."),
+
+    HIVE_OPTIMIZE_BI_REWRITE_COUNT_DISTINCT_SKETCH(
+        "hive.optimize.bi.rewrite.countdistinct.sketch", "hll",
+        new StringSet("hll", "cpc", "theta"),

Review comment:
       I've tried it out - I didn't seen any exceptions the MV match for a 
plain `count(distinct id)` didn't happened....
   when I've changed the default algo no exceptions happened; but matches were 
made incorrectly - so there could be dragons...
   
   I've removed cpc/theta for now...we can add it back later




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 429094)
    Time Spent: 3h 20m  (was: 3h 10m)

> Add option to enable transparent rewrite of count(distinct) into sketch 
> functions
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-23031
>                 URL: https://issues.apache.org/jira/browse/HIVE-23031
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-23031.01.patch, HIVE-23031.02.patch, 
> HIVE-23031.03.patch, HIVE-23031.03.patch, HIVE-23031.03.patch, 
> HIVE-23031.04.patch, HIVE-23031.04.patch
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to