[ https://issues.apache.org/jira/browse/HIVE-23031?focusedWorklogId=427674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427674 ]
ASF GitHub Bot logged work on HIVE-23031: ----------------------------------------- Author: ASF GitHub Bot Created on: 27/Apr/20 15:28 Start Date: 27/Apr/20 15:28 Worklog Time Spent: 10m Work Description: jcamachor commented on a change in pull request #988: URL: https://github.com/apache/hive/pull/988#discussion_r415912339 ########## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ########## @@ -2465,6 +2465,12 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal "If the number of references to a CTE clause exceeds this threshold, Hive will materialize it\n" + "before executing the main query block. -1 will disable this feature."), + HIVE_OPTIMIZE_REWRITE_COUNTDISTINCT_ENABLED("hive.optimize.sketches.rewrite.countdistintct.enabled", false, + "Enables to rewrite COUNT(DISTINCT(X)) queries to be rewritten to use sketch functions."), + + HIVE_OPTIMIZE_REWRITE_COUNT_DISTINCT_SKETCHCLASS("hive.optimize.sketches.rewrite.countdistintct.sketchclass", "hll", Review comment: Yes, agree, that's better. I also like the shorter version for the main config more: `hive.optimize.bi.enabled` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 427674) Time Spent: 1h 50m (was: 1h 40m) > Add option to enable transparent rewrite of count(distinct) into sketch > functions > --------------------------------------------------------------------------------- > > Key: HIVE-23031 > URL: https://issues.apache.org/jira/browse/HIVE-23031 > Project: Hive > Issue Type: Sub-task > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-23031.01.patch, HIVE-23031.02.patch, > HIVE-23031.03.patch, HIVE-23031.03.patch, HIVE-23031.03.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)