[ 
https://issues.apache.org/jira/browse/HIVE-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791466#comment-14791466
 ] 

Ferdinand Xu commented on HIVE-11779:
-------------------------------------

The patch LGTM. Just few minor comments:
{noformat}
92          columnInformation.append(MetaDataFormatUtils.LINE_DELIM);
{noformat}
Please add the line back since it breaks the header and columns.

{noformat}
226           tableInfo.append(String.format(
227               "%" + colsNameConsumed + "s" + 
MetaDataFormatUtils.FIELD_DELIM + "%" + colsTypeConsumed
228                   + "s" + MetaDataFormatUtils.FIELD_DELIM + "%s", "", "", 
commentSegments[i]))
229               .append(MetaDataFormatUtils.LINE_DELIM);
{noformat}
As logic changed(you appand FIELD_DELIM for beeline), please update the 
annotations above.

{noformat}
215         colComment = breakCommentIntoMultipleLines(colComment, 
colsNameConsumed+colsTypeConsumed, prettyOutputNumCols);
{noformat}
Format needed for this need.

> Beeline-cli: Format  the output  of describe pretty table command  in new 
> CLI[beeline-cli branch]
> -------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11779
>                 URL: https://issues.apache.org/jira/browse/HIVE-11779
>             Project: Hive
>          Issue Type: Task
>            Reporter: Ke Jia
>            Assignee: Ke Jia
>         Attachments: HIVE-11779.1-beeline-cli.patch, 
> HIVE-11779.2-beeline-cli.patch, HIVE-11779.3-beeline-cli.patch, 
> HIVE-11779.4-beeline-cli.patch, HIVE-11779.5-beeline-cli.patch
>
>
> In beeline  ,when we use the describe pretty table, it put the result of 
> every row as the first column,and the remaining columns were assigned 
> "NULL".We want to split every row as there columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to