[ https://issues.apache.org/jira/browse/HIVE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078838#comment-17078838 ]
Hive QA commented on HIVE-23107: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12999302/HIVE-23107.06.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 80 failed/errored test(s), 18180 tests executed *Failed tests:* {noformat} TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=162) [unionDistinct_1.q,table_nonprintable.q,file_with_header_footer_aggregation.q,orc_llap_counters1.q,mm_cttas.q,whroot_external1.q,global_limit.q,rcfile_createas1.q,dynamic_partition_pruning_2.q,intersect_merge.q,parquet_struct_type_vectorization.q,results_cache_diff_fs.q,parallel_colstats.q,load_hdfs_file_with_space_in_the_name.q,orc_merge3.q] org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite1 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite2 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion1 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion2 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testSchemaEvolutionCompaction (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testACIDwithSchemaEvolutionAndCompaction (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInitiatorWithMultipleFailedCompactions (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite1 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite2 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion1 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion2 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion3 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testSchemaEvolutionCompaction (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.writeBetweenWorkerAndCleaner (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testCompactionAbort (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteForPartitionedMmTable (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteWithUnionAll (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testOperationsOnCompletedTxnComponentsForMmTable (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteForPartitionedMmTable (batchId=340) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteWithUnionAll (batchId=340) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testOperationsOnCompletedTxnComponentsForMmTable (batchId=340) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testNoBuckets (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testNoBuckets (batchId=344) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMetastoreTablesCleanup (batchId=362) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompactionNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorPartitionCompactionNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMinorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMinorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorPartitionCompaction (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorTableCompaction (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorPartitionCompaction (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorTableCompaction (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.mmTableOpenWriteId (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testCompactionOnDataLoadedInPath (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompaction (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompactionAfterMinor (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompactionDb (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompaction10DeltaDirs (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionAfterMajor (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionDb (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionNotPartitionedWithBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionNotPartitionedWithoutBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionPartitionedWithBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionPartitionedWithoutBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbortInMiddle (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMultipleMinorCompactions (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMinorMmCompactionRemovesAbortedDirs (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMajorCompactionAfterMinor (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMajorCompactionDb (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompaction10DeltaDirs (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionAfterMajor (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionDb (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionNotPartitionedWithBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionNotPartitionedWithoutBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsAvro (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsJsonFile (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsOrc (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsParquet (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsRcFile (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsSequenceFile (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsTextFile (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithoutBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionWithSchemaEvolutionAndBuckets (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionWithSchemaEvolutionNoBucketsMultipleReducers (batchId=258) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMultipleMmMinorCompactions (batchId=258) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21520/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21520/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21520/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 80 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12999302 - PreCommit-HIVE-Build > Remove MIN_HISTORY_LEVEL table > ------------------------------ > > Key: HIVE-23107 > URL: https://issues.apache.org/jira/browse/HIVE-23107 > Project: Hive > Issue Type: Improvement > Components: Hive > Reporter: László Pintér > Assignee: László Pintér > Priority: Major > Attachments: HIVE-23107.01.patch, HIVE-23107.02.patch, > HIVE-23107.03.patch, HIVE-23107.04.patch, HIVE-23107.05.patch, > HIVE-23107.06.patch > > > MIN_HISTORY_LEVEL table is used in two places: > * Cleaner uses it to decide if the files can be removed - this could be > replaced by adding a new column to compaction_queue storing the next_txn_id > when the change was committed, and before cleaning checking the minimum open > transaction id in the TXNS table > * Initiator uses it to decide if some items from TXN_TO_WRITE_ID table can > be removed. This could be replaced by using the WRITE_SET.WS_COMMIT_ID. -- This message was sent by Atlassian Jira (v8.3.4#803005)