[ https://issues.apache.org/jira/browse/HIVE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072781#comment-17072781 ]
Hive QA commented on HIVE-23107: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12998338/HIVE-23107.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 160 failed/errored test(s), 18162 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testFindNextToClean (batchId=318) org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testMarkCleaned (batchId=318) org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testMarkCleanedCleansTxnsAndTxnComponents (batchId=318) org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testMarkCompacted (batchId=318) org.apache.hadoop.hive.ql.TestAcidOnTez.testInsertWithRemoveUnion (batchId=253) org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnMR (batchId=253) org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnTez (batchId=253) org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnMR (batchId=253) org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnTez (batchId=253) org.apache.hadoop.hive.ql.TestTxnCommands.testNonAcidToAcidConversion01 (batchId=363) org.apache.hadoop.hive.ql.TestTxnCommands.testVersioning (batchId=363) org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testCompactWithDelete (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testEmptyInTblproperties (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite1 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite2 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion02 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion1 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion2 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3 (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testOriginalFileReaderWhenNonAcidConvertedToAcid (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.testSchemaEvolutionCompaction (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner (batchId=344) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testACIDwithSchemaEvolutionAndCompaction (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCompactWithDelete (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testEmptyInTblproperties (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInitiatorWithMultipleFailedCompactions (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite1 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite2 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion02 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion1 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion2 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion3 (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testOriginalFileReaderWhenNonAcidConvertedToAcid (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testSchemaEvolutionCompaction (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.writeBetweenWorkerAndCleaner (batchId=358) org.apache.hadoop.hive.ql.TestTxnCommands3.testAcidMetaColumsDecode (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testCompactionAbort (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testDeleteEventPruningOff (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testDeleteEventPruningOn (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommands3.testNotEnoughToCompactNeedsCleaning (batchId=359) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteForPartitionedMmTable (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testInsertOverwriteWithUnionAll (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testOperationsOnCompletedTxnComponentsForMmTable (batchId=318) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteForPartitionedMmTable (batchId=340) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testInsertOverwriteWithUnionAll (batchId=340) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testOperationsOnCompletedTxnComponentsForMmTable (batchId=340) org.apache.hadoop.hive.ql.TestTxnCommandsWithSplitUpdateAndVectorization.testVersioning (batchId=344) org.apache.hadoop.hive.ql.TestTxnConcatenate.testConcatenate (batchId=328) org.apache.hadoop.hive.ql.TestTxnConcatenate.testConcatenateMM (batchId=328) org.apache.hadoop.hive.ql.TestTxnConcatenate.testConcatenatePart (batchId=328) org.apache.hadoop.hive.ql.TestTxnExIm.testImport (batchId=344) org.apache.hadoop.hive.ql.TestTxnExIm.testImportNoTarget (batchId=344) org.apache.hadoop.hive.ql.TestTxnLoadData.loadData (batchId=319) org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataNonAcid2AcidConversion (batchId=319) org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataUpdate (batchId=319) org.apache.hadoop.hive.ql.TestTxnLoadData.testMultiStatement (batchId=319) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCompactStatsGather (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testEmptyCompactionResult (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testNoBuckets (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testNonAcidToAcidVectorzied (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testToAcidConversion02 (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testToAcidConversionMultiBucket (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCompactStatsGather (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testEmptyCompactionResult (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testNoBuckets (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testNonAcidToAcidVectorzied (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testToAcidConversion02 (batchId=344) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testToAcidConversionMultiBucket (batchId=344) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMetastoreTablesCleanup (batchId=362) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompactionNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.droppedPartition (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.droppedTable (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorPartitionCompactionNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMajorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMinorPartitionCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.cleanupAfterMinorTableCompaction (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.droppedPartition (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleaner2.droppedTable (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorPartitionCompaction (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorTableCompaction (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorPartitionCompaction (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorTableCompaction (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.mmTable (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.mmTableOpenWriteId (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.mmTableOriginalsText (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.mmTablePartitioned (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testCompactionOnDataLoadedInPath (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testStatsAfterCompactionPartTbl (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testStatsAfterCompactionPartTblNew (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties (batchId=255) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testCompactionWithSchemaEvolutionAndBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testCompactionWithSchemaEvolutionNoBucketsMultipleReducers (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompaction (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompactionAfterMinor (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompaction10DeltaDirs (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionAfterMajor (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionNotPartitionedWithBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionNotPartitionedWithoutBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionPartitionedWithBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionPartitionedWithoutBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbortInMiddle (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMultipleMinorCompactions (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMinorMmCompactionRemovesAbortedDirs (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMajorCompactionAfterMinor (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompaction10DeltaDirs (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionAfterMajor (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionNotPartitionedWithBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionNotPartitionedWithoutBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsAvro (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsJsonFile (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsOrc (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsParquet (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsRcFile (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsSequenceFile (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithBucketsTextFile (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionPartitionedWithoutBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionWithSchemaEvolutionAndBuckets (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionWithSchemaEvolutionNoBucketsMultipleReducers (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMultipleMmMinorCompactions (batchId=264) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorNoBaseLotsOfDeltas (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorPartitionWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorPartitionWithBaseMissingBuckets (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableLegacy (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithAborted (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithOpenInMiddle (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorNoBaseLotsOfDeltas (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorPartitionWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableLegacy (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithAborted (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorNoBaseLotsOfDeltas (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorPartitionWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorPartitionWithBaseMissingBuckets (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorTableLegacy (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorTableNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorTableWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorWithAborted (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorWithOpenInMiddle (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorNoBaseLotsOfDeltas (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorPartitionWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorTableLegacy (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorTableNoBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorTableWithBase (batchId=329) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorWithAborted (batchId=329) org.apache.hive.hcatalog.streaming.TestStreaming.testNoBuckets (batchId=226) org.apache.hive.streaming.TestStreaming.testAutoRollTransactionBatch (batchId=370) org.apache.hive.streaming.TestStreaming.testNoBuckets (batchId=370) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21369/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21369/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21369/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 160 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12998338 - PreCommit-HIVE-Build > Remove MIN_HISTORY_LEVEL table > ------------------------------ > > Key: HIVE-23107 > URL: https://issues.apache.org/jira/browse/HIVE-23107 > Project: Hive > Issue Type: Improvement > Components: Hive > Reporter: László Pintér > Assignee: László Pintér > Priority: Major > Attachments: HIVE-23107.01.patch, HIVE-23107.02.patch > > > MIN_HISTORY_LEVEL table is used in two places: > * Cleaner uses it to decide if the files can be removed - this could be > replaced by adding a new column to compaction_queue storing the next_txn_id > when the change was committed, and before cleaning checking the minimum open > transaction id in the TXNS table > * Initiator uses it to decide if some items from TXN_TO_WRITE_ID table can > be removed. This could be replaced by using the WRITE_SET.WS_COMMIT_ID. -- This message was sent by Atlassian Jira (v8.3.4#803005)