[
https://issues.apache.org/jira/browse/HIVE-22488?focusedWorklogId=349504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349504
]
ASF GitHub Bot logged work on HIVE-22488:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 02:12
Start Date: 26/Nov/19 02:12
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #843: HIVE-22488
Break up DDLSemanticAnalyzer - extract Table creation analyzers
URL: https://github.com/apache/hive/pull/843#discussion_r350513931
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/createlike/CreateTableLikeDesc.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.hadoop.hive.ql.ddl.table.creation;
Review comment:
Yes, I believe having `create` or `drop` packages within `table` package,
even if we have them next to `column`, `constraint`, etc., is more intuitive.
It seems the additional subpackage does not provide clarity, e.g.,
`creation.drop` or `creation.create` is confusing. Also the `creation` package
seem small enough already, hence another option is that these classes go
directly to the `table` package. I believe there are many options, right now it
is a matter of taste... I would just avoid redundant packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 349504)
Time Spent: 50m (was: 40m)
> Break up DDLSemanticAnalyzer - extract Table creation analyzers
> ---------------------------------------------------------------
>
> Key: HIVE-22488
> URL: https://issues.apache.org/jira/browse/HIVE-22488
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22488.01.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #9: extract the table creationanalyzers from DDLSemanticAnalyzer, and
> move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
