[
https://issues.apache.org/jira/browse/HIVE-22488?focusedWorklogId=349271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349271
]
ASF GitHub Bot logged work on HIVE-22488:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/19 19:01
Start Date: 25/Nov/19 19:01
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #843:
HIVE-22488 Break up DDLSemanticAnalyzer - extract Table creation analyzers
URL: https://github.com/apache/hive/pull/843#discussion_r350228189
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/createlike/CreateTableLikeDesc.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.hadoop.hive.ql.ddl.table.creation;
Review comment:
I choose this package structure to have a balanced structure for the table
related operations. There are 46 of them, and having a package for each of them
would mean an endless list of packages, this is why they were put into packages
by categories.
Yet I understand your point, if someone is looking at an import it seems
odd. One way to solve is that you suggested, or we could replace the "creation"
with something else, like "basic", or "existence", or if you have a better
suggestion :) This way we'll have a more balanced structure, where there is the
main category (table), the sub category (some label), and then the actual
command. But if you believe that having the undoubtedly most straightforward
name that you've suggested is more important than the balanced package
structure, I'm totally fine with that too, I think the most important thing is
to break up the DDLSemanticAnalyzer here, and this question is secondary.
Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 349271)
Time Spent: 40m (was: 0.5h)
> Break up DDLSemanticAnalyzer - extract Table creation analyzers
> ---------------------------------------------------------------
>
> Key: HIVE-22488
> URL: https://issues.apache.org/jira/browse/HIVE-22488
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22488.01.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #9: extract the table creationanalyzers from DDLSemanticAnalyzer, and
> move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
