[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=329950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329950
]
ASF GitHub Bot logged work on HIVE-22329:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 15:36
Start Date: 17/Oct/19 15:36
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #810: HIVE-22329
Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336073950
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverQueue.java
##########
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+
+import org.apache.hadoop.hive.ql.exec.FileSinkOperator;
+import org.apache.hadoop.hive.ql.exec.NodeUtils;
+import org.apache.hadoop.hive.ql.exec.NodeUtils.Function;
+import org.apache.hadoop.hive.ql.exec.Operator;
+import org.apache.hadoop.hive.ql.exec.StatsTask;
+import org.apache.hadoop.hive.ql.exec.Task;
+import org.apache.hadoop.hive.ql.exec.TaskRunner;
+import org.apache.hadoop.hive.ql.exec.mr.MapRedTask;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.plan.MapWork;
+import org.apache.hadoop.hive.ql.plan.ReduceWork;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Handles the queue of tasks that should be executed by the driver.
+ */
+public class DriverQueue {
Review comment:
the apidoc describe it as "queue of tasks"; then I think it should be have
the Task in it name...TaskQueue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329950)
Time Spent: 20m (was: 10m)
> Create DriverContext
> --------------------
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
