[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=329952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329952
]
ASF GitHub Bot logged work on HIVE-22329:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 15:36
Start Date: 17/Oct/19 15:36
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #810: HIVE-22329
Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336078858
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLOperationContext.java
##########
@@ -34,19 +34,19 @@
public class DDLOperationContext {
private final Hive db;
private final HiveConf conf;
- private final DriverContext driverContext;
+ private final DriverQueue driverQueue;
Review comment:
not sure about this; I think we might want to add this "queue" to the
driverContext - as we have a lot of other stuff hanging around here...which
could be moved into the context (conf?)
I would never think about asking for informations from a "queue"...(beyond
the elements it might contain)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329952)
Time Spent: 20m (was: 10m)
> Create DriverContext
> --------------------
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
