[
https://issues.apache.org/jira/browse/HIVE-22298?focusedWorklogId=329287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329287
]
ASF GitHub Bot logged work on HIVE-22298:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/19 17:37
Start Date: 16/Oct/19 17:37
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #818: HIVE-22298: Allow
Llap IO cache for reading tables without delete delta
URL: https://github.com/apache/hive/pull/818#discussion_r335615115
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
##########
@@ -273,38 +273,17 @@ public long getColumnarProjectionSize() {
@Override
public boolean canUseLlapIo(Configuration conf) {
- final boolean hasDelta = deltas != null && !deltas.isEmpty();
- final boolean isAcidRead = AcidUtils.isFullAcidScan(conf);
- final boolean isVectorized = Utilities.getIsVectorized(conf);
- Boolean isSplitUpdate = null;
- if (isAcidRead) {
- final AcidUtils.AcidOperationalProperties acidOperationalProperties
- = AcidUtils.getAcidOperationalProperties(conf);
- isSplitUpdate = acidOperationalProperties.isSplitUpdate();
- // TODO: this is brittle. Who said everyone has to upgrade using upgrade
process?
- assert isSplitUpdate : "should be true in Hive 3.0";
- }
-
- if (isOriginal) {
- if (!isAcidRead && !hasDelta) {
- // Original scan only
- return true;
+ if (AcidUtils.isFullAcidScan(conf)) {
+ if (HiveConf.getBoolVar(conf, ConfVars.LLAP_IO_ACID_ENABLED)
+ && Utilities.getIsVectorized(conf)) {
+ boolean hasDeleteDelta = deltas != null && !deltas.isEmpty();
+ return VectorizedOrcAcidRowBatchReader.canUseLlapIoForAcid(this,
hasDeleteDelta, conf);
+ } else {
+ return false;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329287)
Time Spent: 50m (was: 40m)
> Allow Llap IO cache for reading tables without delete delta
> -----------------------------------------------------------
>
> Key: HIVE-22298
> URL: https://issues.apache.org/jira/browse/HIVE-22298
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22298.2.patch, HIVE-22298.3.patch,
> HIVE-22298.4.patch, HIVE-22298.5.patch, HIVE-22298.6.patch, HIVE-22298.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Since HIVE-19985 we can use Llap IO cache for queries which are not
> explicitly reading ROW_ID even for original files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
