[
https://issues.apache.org/jira/browse/HIVE-22298?focusedWorklogId=329260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329260
]
ASF GitHub Bot logged work on HIVE-22298:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/19 17:01
Start Date: 16/Oct/19 17:01
Worklog Time Spent: 10m
Work Description: b-slim commented on pull request #818: HIVE-22298:
Allow Llap IO cache for reading tables without delete delta
URL: https://github.com/apache/hive/pull/818#discussion_r335596387
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
##########
@@ -182,10 +183,15 @@ private LlapRecordReader(MapWork mapWork, JobConf job,
FileSplit split,
this.isVectorized = HiveConf.getBoolVar(jobConf,
HiveConf.ConfVars.HIVE_VECTORIZATION_ENABLED);
if (isAcidScan) {
+ OrcSplit orcSplit = (OrcSplit) split;
this.acidReader = new VectorizedOrcAcidRowBatchReader(
- (OrcSplit) split, jobConf, Reporter.NULL, null, rbCtx, true);
+ orcSplit, jobConf, Reporter.NULL, null, rbCtx, true);
+ isAcidFormat = !orcSplit.isOriginal();
+ } else {
+ isAcidFormat = false;
}
- this.includes = new IncludesImpl(tableIncludedCols, isAcidScan, rbCtx,
+
+ this.includes = new IncludesImpl(tableIncludedCols, isAcidScan &&
isAcidFormat, rbCtx,
Review comment:
this can be simplified to `isAcidFormat ` instead of `isAcidScan &&
isAcidFormat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329260)
Time Spent: 20m (was: 10m)
> Allow Llap IO cache for reading tables without delete delta
> -----------------------------------------------------------
>
> Key: HIVE-22298
> URL: https://issues.apache.org/jira/browse/HIVE-22298
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22298.2.patch, HIVE-22298.3.patch,
> HIVE-22298.4.patch, HIVE-22298.5.patch, HIVE-22298.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since HIVE-19985 we can use Llap IO cache for queries which are not
> explicitly reading ROW_ID even for original files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
