[jira] [Work logged] (HIVE-21958) The list of table expression in the inclusion and exclusion list should be separated by '|' instead of comma.

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/HIVE-21958?focusedWorklogId=273129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273129
 ]

ASF GitHub Bot logged work on HIVE-21958:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jul/19 07:48
            Start Date: 08/Jul/19 07:48
    Worklog Time Spent: 10m 
      Work Description: sankarh commented on pull request #705: HIVE-21958 : 
The list of table expression in the inclusion and exclusion list should be 
separated by '|' instead of comma.
URL: https://github.com/apache/hive/pull/705#discussion_r300961527
 
 

 ##########
 File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTableLevelReplicationScenarios.java
 ##########
 @@ -263,12 +263,12 @@ public void testIncorrectTablePolicyInReplDump() throws 
Throwable {
     String[] replicatedTables = new String[] {};
     boolean failed;
     String[] invalidReplPolicies = new String[] {
-        primaryDbName + ".t1.t2", // Two explicit table names not allowed.
-        primaryDbName + ".['t1'].t2", // Table name and include list not 
allowed.
-        primaryDbName + ".t1.['t2']", // Table name and exclude list not 
allowed.
-        primaryDbName + ".[t1].t2", // Table name and include list not allowed.
-        primaryDbName + ".['t1+'].", // Abrubtly ended dot.
-        primaryDbName + "..[]" // Multiple dots
+        primaryDbName + ".t1.t2", // Didn't enclose table pattern within 
single quotes.
+        primaryDbName + ".'t1'.t2", // Table name and include list not allowed.
+        primaryDbName + ".t1.'t2'", // Table name and exclude list not allowed.
+        primaryDbName + ".'t1+'.", // Abrubtly ended dot.
 
 Review comment:
   We can add the empty include/exclude list in this test case.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 273129)
    Time Spent: 2h 40m  (was: 2.5h)

> The list of table expression in the inclusion and exclusion list should be 
> separated by '|' instead of comma.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21958
>                 URL: https://issues.apache.org/jira/browse/HIVE-21958
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21958.01.patch, HIVE-21958.02.patch, 
> HIVE-21958.03.patch
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Java regex expression does not support comma. If user wants multiple 
> expression to be present in the include or exclude list, then the expressions 
> can be provided separated by pipe ('|') character. The policy will look 
> something like db_name.'(t1*)|(t3)'.'t100'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)