[jira] [Work logged] (HIVE-21958) The list of table expression in the inclusion and exclusion list should be separated by '|' instead of comma.

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/HIVE-21958?focusedWorklogId=273100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273100
 ]

ASF GitHub Bot logged work on HIVE-21958:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jul/19 07:07
            Start Date: 08/Jul/19 07:07
    Worklog Time Spent: 10m 
      Work Description: maheshk114 commented on pull request #705: HIVE-21958 : 
The list of table expression in the inclusion and exclusion list should be 
separated by '|' instead of comma.
URL: https://github.com/apache/hive/pull/705#discussion_r300948134
 
 

 ##########
 File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTableLevelReplicationScenarios.java
 ##########
 @@ -313,8 +313,8 @@ public void testIncorrectTablePolicyInReplDump() throws 
Throwable {
     }
     Assert.assertTrue(failed);
 
-    // Invalid pattern where we didn't enclose table pattern within single or 
double quotes.
-    replPolicy = primaryDbName + ".[t1].[t2]";
+    // Invalid pattern where where table list is empty.
+    replPolicy = primaryDbName + ".''.'t2'";
 
 Review comment:
   it's confusing ..if empty list ..that means include all ? if yes, then user 
has to give empty exclude list or exclude list as *  for dump only function ? i 
think for simplicity we should not allow this special case ..if user wants then 
they can use regex to exclude all tables
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 273100)
    Time Spent: 2h 10m  (was: 2h)

> The list of table expression in the inclusion and exclusion list should be 
> separated by '|' instead of comma.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21958
>                 URL: https://issues.apache.org/jira/browse/HIVE-21958
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21958.01.patch, HIVE-21958.02.patch, 
> HIVE-21958.03.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Java regex expression does not support comma. If user wants multiple 
> expression to be present in the include or exclude list, then the expressions 
> can be provided separated by pipe ('|') character. The policy will look 
> something like db_name.'(t1*)|(t3)'.'t100'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)