[
https://issues.apache.org/jira/browse/HIVE-21732?focusedWorklogId=246651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246651
]
ASF GitHub Bot logged work on HIVE-21732:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 10:11
Start Date: 22/May/19 10:11
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #634: HIVE-21732:
Configurable injection of latency for LLAP task execution
URL: https://github.com/apache/hive/pull/634#discussion_r286414322
##########
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapLoadGeneratorService.java
##########
@@ -40,7 +44,32 @@ public void testLoadGenerator() throws
InterruptedException, UnknownHostExceptio
service.init(conf);
service.start();
- Thread.sleep(10000);
+ Thread.sleep(5000);
+ assertEquals("The number of threads is not correct",
+ Runtime.getRuntime().availableProcessors(), service.threads.length);
+ for(int i = 0; i < service.threads.length; i++) {
+ assertTrue("The thread [" + i + "] should be alive",
service.threads[i].isAlive());
+ }
+ service.stop();
+ Thread.sleep(5000);
+ for(int i = 0; i < service.threads.length; i++) {
+ Thread.State state = service.threads[i].getState();
Review comment:
I think this is used. The service is stopped and it interrupts the load
generating threads.
After that we check if the threads are really stopped or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 246651)
Time Spent: 5.5h (was: 5h 20m)
> Configurable injection of load for LLAP task execution
> ------------------------------------------------------
>
> Key: HIVE-21732
> URL: https://issues.apache.org/jira/browse/HIVE-21732
> Project: Hive
> Issue Type: Test
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21732.2.patch, HIVE-21732.3.patch,
> HIVE-21732.4.patch, HIVE-21732.5.patch, HIVE-21732.6.patch,
> HIVE-21732.7.patch, HIVE-21732.8.patch, HIVE-21732.patch
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> For evaluating testing, it would be good to have a configurable way to inject
> latency for LLAP tasks.
> The configuration should be able to control how much latency is injected into
> each daemon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
