[ https://issues.apache.org/jira/browse/HIVE-21732?focusedWorklogId=245331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245331 ]
ASF GitHub Bot logged work on HIVE-21732: ----------------------------------------- Author: ASF GitHub Bot Created on: 20/May/19 17:01 Start Date: 20/May/19 17:01 Worklog Time Spent: 10m Work Description: odraese commented on pull request #634: HIVE-21732: Configurable injection of latency for LLAP task execution URL: https://github.com/apache/hive/pull/634#discussion_r285677877 ########## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ########## @@ -627,6 +627,15 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal "internal usage only, used only in test mode. If set false, the operation logs, and the " + "operation log directory will not be removed, so they can be found after the test runs."), + HIVE_TEST_LOAD_HOSTNAMES("hive.test.load.hostnames", "", + "Specify host names for load testing. (e.g., \"host1,host2,host3\"). Leave it empty if no " + + "load generation is needed (eg. for production)."), + HIVE_TEST_LOAD_INTERVAL("hive.test.load.interval", "10ms", new TimeValidator(TimeUnit.MILLISECONDS), + "The interval length used for load generation in milliseconds"), Review comment: I think, this description could add a little detail here. What happens per interval? Is this 10ms of load and then (how long) no load. Is this a complete iterations and does a factor of 0.2 mean that 2ms are LOAD and 8ms are idle? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 245331) Time Spent: 3h 50m (was: 3h 40m) > Configurable injection of load for LLAP task execution > ------------------------------------------------------ > > Key: HIVE-21732 > URL: https://issues.apache.org/jira/browse/HIVE-21732 > Project: Hive > Issue Type: Test > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21732.2.patch, HIVE-21732.3.patch, > HIVE-21732.4.patch, HIVE-21732.5.patch, HIVE-21732.6.patch, HIVE-21732.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > For evaluating testing, it would be good to have a configurable way to inject > latency for LLAP tasks. > The configuration should be able to control how much latency is injected into > each daemon. -- This message was sent by Atlassian JIRA (v7.6.3#76005)