[ https://issues.apache.org/jira/browse/HIVE-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756789#comment-16756789 ]
Hive QA commented on HIVE-21045: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color} | {color:red} /data/hiveptest/logs/PreCommit-HIVE-Build-15854/patches/PreCommit-HIVE-Build-15854.patch does not apply to master. Rebase required? Wrong Branch? See http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15854/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Add HMS total api count stats and connection pool stats to metrics > ------------------------------------------------------------------ > > Key: HIVE-21045 > URL: https://issues.apache.org/jira/browse/HIVE-21045 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore > Reporter: Karthik Manamcheri > Assignee: Karthik Manamcheri > Priority: Minor > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-21045.1.patch, HIVE-21045.2.branch-3.patch, > HIVE-21045.2.patch, HIVE-21045.3.patch, HIVE-21045.4.patch, > HIVE-21045.5.patch, HIVE-21045.6.patch, HIVE-21045.7.patch, > HIVE-21045.branch-3.patch > > > There are two key metrics which I think we lack and which would be really > great to help with scaling visibility in HMS. > *Total API calls duration stats* > We already compute and log the duration of API calls in the {{PerfLogger}}. > We don't have any gauge or timer on what the average duration of an API call > is for the past some bucket of time. This will give us an insight into if > there is load on the server which is increasing the average API response time. > > *Connection Pool stats* > We can use different connection pooling libraries such as bonecp or hikaricp. > These pool managers expose statistics such as average time waiting to get a > connection, number of connections active, etc. We should expose this as a > metric so that we can track if the the connection pool size configured is too > small and we are saturating! > These metrics would help catch problems with HMS resource contention before > they actually have jobs failing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)