[ https://issues.apache.org/jira/browse/HIVE-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754069#comment-16754069 ]
Hive QA commented on HIVE-21045: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12956467/HIVE-21045.branch-3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 132 failed/errored test(s), 14481 tests executed *Failed tests:* {noformat} TestAddPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestAddPartitionsFromPartSpec - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAdminUser - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestAggregateStatsCache - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestAlterPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAppendPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=274) TestCachedStore - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestCatalogCaching - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestCatalogNonDefaultClient - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestCatalogNonDefaultSvr - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestCatalogOldClient - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestCatalogs - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestCheckConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestDatabases - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDeadline - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestDefaultConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDropPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=274) TestEmbeddedHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) (batchId=231) TestExchangePartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestFMSketchSerialization - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestFilterHooks - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestForeignKey - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestFunctions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestGetPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestGetPartitionsUsingProjectionAndFilterSpecs - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestGetTableMeta - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHLLNoBias - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestHLLSerialization - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestHdfsUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestHiveAlterHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHiveMetaStoreGetMetaConf - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHiveMetaStorePartitionSpecs - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestHiveMetaStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestHiveMetaStoreTimeout - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHiveMetaStoreTxns - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHiveMetaStoreWithEnvironmentContext - did not produce a TEST-*.xml file (likely timed out) (batchId=233) TestHiveMetaToolCommandLine - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestHiveMetastoreCli - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHyperLogLog - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestHyperLogLogDense - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestHyperLogLogMerge - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestHyperLogLogSparse - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestJSONMessageDeserializer - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestListPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestLockRequestBuilder - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestMarkPartition - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMarkPartitionRemote - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreConnectionUrlHook - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetaStoreEndFunctionListener - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMetaStoreEventListener - did not produce a TEST-*.xml file (likely timed out) (batchId=234) TestMetaStoreEventListenerOnlyOnCommit - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreEventListenerWithOldConf - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreInitListener - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreListenersError - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreSchemaFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetaStoreSchemaInfo - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreServerUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetaToolTaskExecuteJDOQLQuery - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetaToolTaskListFSRoot - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetaToolTaskUpdateLocation - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetastoreConf - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMetastoreSchemaTool - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestMetrics - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=274) TestMiniDruidKafkaCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=274) TestMsckCheckPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestNotNullConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestObjectStore - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestObjectStoreInitRetry - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestObjectStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestObjectStoreStatementVerify - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestOldSchema - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestPartitionManagement - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestPartitionNameWhitelistValidation - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestPartitionProjectionEvaluator - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestPreUpgradeTool - did not produce a TEST-*.xml file (likely timed out) (batchId=332) TestPrimaryKey - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestRawStoreProxy - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestRemoteHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) (batchId=232) TestRemoteHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely timed out) (batchId=226) TestRemoteHiveMetaStoreZK - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestRemoteHiveMetaStoreZKBindHost - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestRemoteUGIHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestRetriesInRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestRuntimeStats - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestSchemaToolForMetastore - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestSetUGIOnBothClientServer - did not produce a TEST-*.xml file (likely timed out) (batchId=229) TestSetUGIOnOnlyClient - did not produce a TEST-*.xml file (likely timed out) (batchId=227) TestSetUGIOnOnlyServer - did not produce a TEST-*.xml file (likely timed out) (batchId=237) TestSparseEncodeHash - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestStats - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestStatsSetupConst - did not produce a TEST-*.xml file (likely timed out) (batchId=239) TestTableIterable - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestTablesCreateDropAlterTruncate - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTablesGetExists - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestTablesList - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=274) TestTxnHandlerNegative - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTxnUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestUniqueConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=228) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_all] (batchId=71) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_auth] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[results_cache_2] (batchId=179) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sharedwork] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=166) org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=333) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.alterBogusCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.alterCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.alterCatalogNoChange (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.createCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.createExistingCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.createExistingCatalogWithIfNotExists (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveDatabase (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveDatabaseWithExistingDbOfSameNameAlreadyInTargetCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveDbToNonExistentCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveNonExistentDatabase (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveNonExistentTable (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveTable (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveTableToNonExistentDb (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveTableWithExistingTableOfSameNameAlreadyInTargetDatabase (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.moveTableWithinCatalog (batchId=247) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateLocations (batchId=223) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateNullValues (batchId=223) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateSequences (batchId=223) org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testManagedPaths (batchId=251) org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation (batchId=259) org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=326) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15810/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15810/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15810/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 132 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12956467 - PreCommit-HIVE-Build > Add HMS total api count stats and connection pool stats to metrics > ------------------------------------------------------------------ > > Key: HIVE-21045 > URL: https://issues.apache.org/jira/browse/HIVE-21045 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore > Reporter: Karthik Manamcheri > Assignee: Karthik Manamcheri > Priority: Minor > Fix For: 3.2.0 > > Attachments: HIVE-21045.1.patch, HIVE-21045.2.patch, > HIVE-21045.3.patch, HIVE-21045.4.patch, HIVE-21045.5.patch, > HIVE-21045.6.patch, HIVE-21045.7.patch, HIVE-21045.branch-3.patch > > > There are two key metrics which I think we lack and which would be really > great to help with scaling visibility in HMS. > *Total API calls duration stats* > We already compute and log the duration of API calls in the {{PerfLogger}}. > We don't have any gauge or timer on what the average duration of an API call > is for the past some bucket of time. This will give us an insight into if > there is load on the server which is increasing the average API response time. > > *Connection Pool stats* > We can use different connection pooling libraries such as bonecp or hikaricp. > These pool managers expose statistics such as average time waiting to get a > connection, number of connections active, etc. We should expose this as a > metric so that we can track if the the connection pool size configured is too > small and we are saturating! > These metrics would help catch problems with HMS resource contention before > they actually have jobs failing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)