[ https://issues.apache.org/jira/browse/HIVE-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606519#comment-16606519 ]
Hive QA commented on HIVE-17684: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12938705/HIVE-17684.06.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 34 failed/errored test(s), 14928 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf] (batchId=56) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_1] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join11] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join14] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join15] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join1] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join20] (batchId=94) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=77) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join33] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_stats] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_without_localtask] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketmapjoin9] (batchId=17) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_join2] (batchId=41) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[empty_join] (batchId=84) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_convert_join] (batchId=57) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join26] (batchId=20) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join30] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join32] (batchId=20) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join33] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin2] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin3] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nonblock_op_deduplicate] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_join] (batchId=20) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_mapjoin10] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_6] (batchId=94) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_8] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_left_outer_join] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_outer_join2] (batchId=32) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_outer_join3] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_mapjoin3] (batchId=12) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39] (batchId=266) org.apache.hive.jdbc.miniHS2.TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics (batchId=255) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13631/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13631/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13631/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 34 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12938705 - PreCommit-HIVE-Build > HoS memory issues with MapJoinMemoryExhaustionHandler > ----------------------------------------------------- > > Key: HIVE-17684 > URL: https://issues.apache.org/jira/browse/HIVE-17684 > Project: Hive > Issue Type: Bug > Components: Spark > Reporter: Sahil Takiar > Assignee: Misha Dmitriev > Priority: Major > Attachments: HIVE-17684.01.patch, HIVE-17684.02.patch, > HIVE-17684.03.patch, HIVE-17684.04.patch, HIVE-17684.05.patch, > HIVE-17684.06.patch > > > We have seen a number of memory issues due the {{HashSinkOperator}} use of > the {{MapJoinMemoryExhaustionHandler}}. This handler is meant to detect > scenarios where the small table is taking too much space in memory, in which > case a {{MapJoinMemoryExhaustionError}} is thrown. > The configs to control this logic are: > {{hive.mapjoin.localtask.max.memory.usage}} (default 0.90) > {{hive.mapjoin.followby.gby.localtask.max.memory.usage}} (default 0.55) > The handler works by using the {{MemoryMXBean}} and uses the following logic > to estimate how much memory the {{HashMap}} is consuming: > {{MemoryMXBean#getHeapMemoryUsage().getUsed() / > MemoryMXBean#getHeapMemoryUsage().getMax()}} > The issue is that {{MemoryMXBean#getHeapMemoryUsage().getUsed()}} can be > inaccurate. The value returned by this method returns all reachable and > unreachable memory on the heap, so there may be a bunch of garbage data, and > the JVM just hasn't taken the time to reclaim it all. This can lead to > intermittent failures of this check even though a simple GC would have > reclaimed enough space for the process to continue working. > We should re-think the usage of {{MapJoinMemoryExhaustionHandler}} for HoS. > In Hive-on-MR this probably made sense to use because every Hive task was run > in a dedicated container, so a Hive Task could assume it created most of the > data on the heap. However, in Hive-on-Spark there can be multiple Hive Tasks > running in a single executor, each doing different things. -- This message was sent by Atlassian JIRA (v7.6.3#76005)